only run drop all if database was used in the test #5870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Previously, drop all would be run at the end of every integration test, including if the test contained no test systems that were currently activated. In other words, drop all would be run against Snowflake after running
PSqlExecutorTest
. Because drop all on Snowflake is expensive, this means that test runs were taking minutes (possibly hours) longer than necessary.Things to be aware of
Things to worry about
Additional Context