chore: invoke deprecated methods in default supports method for backwards compatibility #5897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR:
Invoke deprecated methods in default supports method to ensure that extensions are not broken, but one day when those are removed it will return only true
Description
The new support
method
was introduced in PR #5619 so specially NoSQL databases can check for other supports asCollections
without changing Database class and adding asupportsCollections()
method.In core all the locations were
supportsSequences()
existed were changed to supports(Sequence) , and all *Database classes had this new method implemented. But extensions don't have it, so they could return the wrong value. For instance, BigQuery doesn't support sequences but would start to return true to core.With this fix we continue to return what is expected.
Impact