Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FastCheck refactoring #5925

Merged
merged 7 commits into from
Jun 19, 2024
Merged

feat: FastCheck refactoring #5925

merged 7 commits into from
Jun 19, 2024

Conversation

filipelautert
Copy link
Collaborator

@filipelautert filipelautert commented May 16, 2024

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5784

Decouples fast check from AbstractUpdateCommandStep by moving it to a new Singleton service as it is becoming too big and confusing to be just a method

@filipelautert
Copy link
Collaborator Author

@MalloD12 do we still working on this one?

@MalloD12
Copy link
Contributor

@MalloD12 do we still working on this one?

I was talking a few mins ago with @tati-qalified about it. We need to see a way to add the test provided by the reporter of the issue, but that test is only working on Spring.

@filipelautert filipelautert requested a deployment to internal June 10, 2024 20:42 — with GitHub Actions Abandoned
@rberezen
Copy link
Contributor

@filipelautert
Copy link
Collaborator Author

@filipelautert @MalloD12 could you please check test failure? https://github.com/liquibase/liquibase/actions/runs/9518324183/job/26239445986?pr=5925

@rberezen whow, that's a real failure. Let me check.

@filipelautert
Copy link
Collaborator Author

@filipelautert @MalloD12 could you please check test failure? https://github.com/liquibase/liquibase/actions/runs/9518324183/job/26239445986?pr=5925

@rberezen whow, that's a real failure. Let me check.

@rberezen nah, just a broken test. Fixed!

@filipelautert filipelautert requested a deployment to internal June 14, 2024 18:33 — with GitHub Actions Abandoned
@filipelautert filipelautert requested a deployment to internal June 14, 2024 18:40 — with GitHub Actions Abandoned
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Thank you, @filipelautert!

@filipelautert filipelautert merged commit 23bf269 into master Jun 19, 2024
66 of 72 checks passed
@filipelautert filipelautert deleted the refactor-fast-check branch June 19, 2024 17:06
@filipelautert filipelautert added this to the 1NEXT milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AbstractUpdateCommandStep.upToDateFastCheck global cache does not detect DB recreation
4 participants