-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FastCheck refactoring #5925
Conversation
@MalloD12 do we still working on this one? |
I was talking a few mins ago with @tati-qalified about it. We need to see a way to add the test provided by the reporter of the issue, but that test is only working on Spring. |
1ebd05a
to
33a9c4b
Compare
liquibase-integration-tests/src/test/java/liquibase/dbtest/pgsql/PostgreSQLIntegrationTest.java
Dismissed
Show dismissed
Hide dismissed
liquibase-integration-tests/src/test/java/liquibase/dbtest/pgsql/PostgreSQLIntegrationTest.java
Dismissed
Show dismissed
Hide dismissed
liquibase-integration-tests/src/test/java/liquibase/dbtest/pgsql/PostgreSQLIntegrationTest.java
Dismissed
Show dismissed
Hide dismissed
…o big to be just a method in AbstractUpdateCommandStep
f00460d
to
97ed57e
Compare
@filipelautert @MalloD12 could you please check test failure? |
@rberezen whow, that's a real failure. Let me check. |
@rberezen nah, just a broken test. Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. Thank you, @filipelautert!
Impact
Description
Fixes #5784
Decouples fast check from AbstractUpdateCommandStep by moving it to a new Singleton service as it is becoming too big and confusing to be just a method