Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSGi import for org.apache.commons.io #6015

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

vkolomeyko
Copy link

@vkolomeyko vkolomeyko commented Jun 17, 2024

Fixes: #6020

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)

Description

Since LB has a compile dependency on org.apache.commons.io package, it is incorrect to list it as an optional dependency.

After the change the section will have:

Import-Package: ...,org.apache.commons.io;version="[2.16.1,3)"

Additional Context

Since commons-io library perform a multi-version export, this change is also putting some version constrains to pick the latest version.

After the change the section will have:
```
Import-Package: ...,org.apache.commons.io;ver
 sion="[2.16.1,3)"
 ```
After the change the section will have:
```
Import-Package: ...,org.apache.commons.io;ver
 sion="[2.16.1,3)"
 ```
@vkolomeyko vkolomeyko marked this pull request as ready for review June 18, 2024 10:26
@filipelautert
Copy link
Collaborator

Hey @vkolomeyko - based on #6021, do you think we will need to add the other apache commons in this list too?

@vkolomeyko
Copy link
Author

Hey @vkolomeyko - based on #6021, do you think we will need to add the other apache commons in this list too?

@filipelautert - it might be a good idea. Let me do that, as part of this PR.
Outside of org.apache.commons.io I can only see in the code import org.apache.commons.lang3.

@vkolomeyko vkolomeyko requested a deployment to external June 19, 2024 17:24 — with GitHub Actions Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Development
Development

Successfully merging this pull request may close these issues.

OSGi dependency on Apache Commons IO is declared incorrectly
3 participants