Cleanup checksum classes #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Character could be removed via String::replace method, rather then String::replaceAll method based on regexp. This should lead to better performance and less memory consumption.
Precompiled matcher should improve overall performance. Also, it improves code readability by regexp groups. To improve code, delimiter ':' was also extracted to constant. That leaded to changed CheckSum::toString method. Regexp pattern was changed to be more strict and acept checksum only as alphanumeric signs, as it is described in documentation. Pattern leaved case insensitive.
This test tests nothing, since hashcode, as int primitive could be never null in JVM.
Previous version do not admit old Mac systems with linendings like single CR. After fix dead code in comment was uncommented and works.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for CheckSum and its test classes.