-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.13.0 tests fail with python 3.12 on Gentoo #708
Comments
Full build and test log is available here if it helps https://pentoo.org/~zero/app-misc:liquidctl-1.13.0:20240521-173117.log |
You seem to be using docopt-ng... While I can't tell for sure (the build logs don't even mention the use of docopt-ng, much less a specific version), the issue is probably caused by the monkeypatching or I'll post a patch for you to try in a bit. |
When setting up for the CLI tests, we inadvertently change the type of sys.argv from list to tuple. That worked with OG docopt, but breaks docopt-ng. More importantly, the Python docs say sys.argv is a _list_. So even though docopt was able to handle it being a tuple, and docopt-ng seems (from a cursory look at its source) to still handle it being a string, let's use the correct type. Fixes: #708
Please give #709 a test, and let me know if it fixes this issue. |
Awesome, thanks for the quick work. Yes, this does fix the issue with the tests failing. All tests now pass except for the known bug here #661 |
Thanks! |
When setting up for the CLI tests, we inadvertently change the type of sys.argv from list to tuple. That worked with OG docopt, but breaks docopt-ng. More importantly, the Python docs say sys.argv is a _list_. So even though docopt was able to handle it being a tuple, and docopt-ng seems (from a cursory look at its source) to still handle it being a string, let's use the correct type. Fixes: #708
Describe the bug
tests fail:
Commands executed
pytest using python 3.12
Output of all relevant commands with
--debug
flagAffected device
test_cli.py
Does your version of liquidctl support the device in question?
Yes, my version supports it
Operating system and version
Gentoo Linux
Installation method
Gentoo package manger
Version of liquidctl
v1.13.0
The text was updated successfully, but these errors were encountered: