test_cli: don't change the type of sys.argv when monkeypatching it #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting up for the CLI tests, we inadvertently change the type of sys.argv from list to tuple. That worked with OG docopt, but breaks docopt-ng. More importantly, the Python docs say sys.argv is a _list_. So even though docopt was able to handle it being a tuple, and docopt-ng seems (from a cursory look at its source) to still handle it being a string, let's use the correct type. Fixes: #708
|
Tested and confirmed to resolve #708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up for the CLI tests, we inadvertently change the type of sys.argv from list to tuple. That worked with OG docopt, but breaks docopt-ng. More importantly, the Python docs say sys.argv is a list.
So even though docopt was able to handle it being a tuple, and docopt-ng seems (from a cursory look at its source) to still handle it being a string, let's use the correct type.
Fixes: #708
Checklist:
docs/*guide.mddevice guides, with "new/changed in" notesliquidctl.8Linux/Unix/Mac OS man pagedocs/developer/protocolNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)gitMRLVNew driver?
docs/developer/protocol/