Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable SMT when GOARCH == amd64 #562

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

Callisto13
Copy link
Member

I have done this very simply for now as this is the only setting I have so far found which is not supported on ARM. If/when I find there are more features which vary based on architecture we can make this more elaborate, but for now this will work for us.

Closes #558

I have done this very simply for now as this is the only setting I have
so far found which is not supported on ARM. If/when I find there are
more features which vary based on architecture we can make this more
elaborate, but for now this will work for us.
@Callisto13 Callisto13 added the kind/feature New feature or request label Oct 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 56.61% // Head: 56.61% // No change to project coverage 👍

Coverage data is based on head (b804f3a) compared to base (9f64a55).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   56.61%   56.61%           
=======================================
  Files          57       57           
  Lines        2768     2768           
=======================================
  Hits         1567     1567           
  Misses       1060     1060           
  Partials      141      141           
Impacted Files Coverage Δ
infrastructure/firecracker/config.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Callisto13 Callisto13 merged commit 76a0a37 into liquidmetal-dev:main Oct 17, 2022
@Callisto13 Callisto13 deleted the smt-arm branch October 17, 2022 15:45
@Callisto13 Callisto13 mentioned this pull request Oct 19, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMT (Simultaneous Multithreading) is not supported by firecracker on ARM
3 participants