-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged dependabot pull requests, fixed gosec linter #71
Conversation
Changed to daily interval for dependabot
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20201016220609-9e8e0b390897 to 0.13.0. - [Commits](https://github.com/golang/crypto/commits/v0.13.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…g/x/crypto-0.13.0 Bump golang.org/x/crypto from 0.0.0-20201016220609-9e8e0b390897 to 0.13.0
Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.3.1 to 1.5.1. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.3.1...v1.5.1) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…m/spf13/cast-1.5.1 Bump github.com/spf13/cast from 1.3.1 to 1.5.1
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.7.1 to 1.16.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.7.1...v1.16.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…m/spf13/viper-1.16.0 Bump github.com/spf13/viper from 1.7.1 to 1.16.0
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.7.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.1.1...v1.7.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/c-bata/go-prompt](https://github.com/c-bata/go-prompt) from 0.2.5 to 0.2.6. - [Changelog](https://github.com/c-bata/go-prompt/blob/master/CHANGELOG.md) - [Commits](c-bata/go-prompt@v0.2.5...v0.2.6) --- updated-dependencies: - dependency-name: github.com/c-bata/go-prompt dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…m/spf13/cobra-1.7.0 Bump github.com/spf13/cobra from 1.1.1 to 1.7.0
…m/c-bata/go-prompt-0.2.6 Bump github.com/c-bata/go-prompt from 0.2.5 to 0.2.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🤖
Ideally going forward to improve this project more:
- Add at least basic "smoke test" unit/integration tests.
- Wrap 1 in a github action check, required via branch protection rule on main branch.
- Consider updating current semi-manual release process to automatically publish a github release when a commit enters main branch.
- Setup github codeowners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -3,26 +3,15 @@ module github.com/liquidweb/liquidweb-cli | |||
go 1.13 | |||
|
|||
require ( | |||
github.com/c-bata/go-prompt v0.2.5 | |||
github.com/fsnotify/fsnotify v1.4.9 // indirect | |||
github.com/c-bata/go-prompt v0.2.6 | |||
github.com/google/go-github/v32 v32.1.0 | |||
github.com/k0kubun/go-ansi v0.0.0-20180517002512-3bf9e2903213 | |||
github.com/liquidweb/go-lwApi v0.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a card for this line. I'll look at it next wek if you want for you.
yeah @sgsullivan we're going to be putting more time into this, and I've always been obsessive about testing and stuff like github actions and codeowners. Expect to see more over time. Currently I'm more focused on terraform, and there's shortly going to be a massive change to |
Merged dependabot pull requests, fixed gosec linter issues during build