Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for libraries in private repositories #109

Closed
gphilipp opened this issue Sep 15, 2021 · 14 comments
Closed

Support for libraries in private repositories #109

gphilipp opened this issue Sep 15, 2021 · 14 comments
Labels
bug Something isn't working

Comments

@gphilipp
Copy link

gphilipp commented Sep 15, 2021

When running antq against our repos I get an error when it tries to download a private library.

Eg if I run on a leiningen project:
clojure -Sdeps '{:deps {com.github.liquidz/antq {:mvn/version "RELEASE"}}}' -M -m antq.core

It produces:

...
Execution error (IOException) at sun.net.www.protocol.http.HttpURLConnection/getInputStream0 (HttpURLConnection.java:1924).
Server returned HTTP response code: 401 for URL: https://fundingcircle.jfrog.io/fundingcircle/libs-release-local/turbulent-metrics-kafka-streams/turbulent-metrics-kafka-streams/0.4.0/turbulent-metrics-kafka-streams-0.4.0.pom

This is a homemade lib which is hosted in a private repo declared inside project.clj.
I have the same issue if running the same command against a tools.deps project.

  • Running lein ancient works fine against the leiningen project and reports all libs version diff.
  • Running clojure -Sdeps '{:deps {olical/depot {:mvn/version "RELEASE"}}}' -M -m depot.outdated.main runs fine against the tools.deps project and reports the diff for the private lib too.
@liquidz
Copy link
Owner

liquidz commented Sep 15, 2021

@gphilipp Thank for your reporting!

Hmm, I'll have a look later.

@jlesquembre
Copy link

I'm having the same issue with a deps.edn project.

Looks like antq is not taking ~/.m2/settings.xml nor ~/.config/clojure/deps.edn into consideration

@liquidz
Copy link
Owner

liquidz commented Nov 11, 2021

@jlesquembre Thanks!
I could finally reproduce the problem with Nexus3.
I'll try to fix it.

liquidz added a commit that referenced this issue Nov 12, 2021
@liquidz
Copy link
Owner

liquidz commented Nov 12, 2021

@gphilipp @jlesquembre
I've tried to fix in feature/private-repos branch, and it seems working well in my environment.

Could you try feature/private-repos branch?

@liquidz liquidz added the bug Something isn't working label Nov 12, 2021
@jlesquembre
Copy link

thanks @liquidz , but unfortunately still not working for me.
My setup is as described in the deps cli docs: https://clojure.org/reference/deps_and_cli#_maven_s3_repos
The url to the private repo is in my deps.edn file (in ~/.config/clojure/deps.edn) and the username/password in the maven config (~/.m2/settings.xml)

@liquidz
Copy link
Owner

liquidz commented Nov 13, 2021

@jlesquembre Ah, I missed to read :mvn/repos in ~/.config/clojure/deps.edn, sorry.
I'll fix it tomorrow.

@liquidz
Copy link
Owner

liquidz commented Nov 13, 2021

@jlesquembre I fixed the problem.
Could you try feature/private-repos branch again?

@liquidz
Copy link
Owner

liquidz commented Nov 14, 2021

I'm tweaking the logic a little bit.
Soon to commit.

@liquidz
Copy link
Owner

liquidz commented Nov 14, 2021

Commited

@jlesquembre
Copy link

@liquidz It works :)

Thanks a lot, great work with antq

@liquidz
Copy link
Owner

liquidz commented Nov 15, 2021

@jlesquembre Thanks for your confirmation!

@liquidz
Copy link
Owner

liquidz commented Nov 17, 2021

@jlesquembre @gphilipp
I just released v1.3.0 #122

@liquidz liquidz closed this as completed Nov 17, 2021
@jlesquembre
Copy link

Thank you @liquidz !

@gphilipp
Copy link
Author

Hey @liquidz, thanks for fixing this, I've just tried 1.3.0 and it works flawlessly now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants