Fix not to add nil as username and password #109

src/antq/util/maven.clj

@@ -75,7 +75,9 @@
     ;; In Leiningen, authentication information is defined in project.clj instead of ~/.m2/settings.xml,
     ;; so if there is authentication information in `:repositories`, apply to `settings`
     (doseq [[id {:keys [username password]}] (:repositories opts)]
-      (when-not (contains? server-ids id)
+      (when (and username
+                 password
+                 (not (contains? server-ids id)))
         (.addServer settings
                     (new-repository-server {:id id :username username :password password}))))
     settings))

test/antq/util/maven_test.clj

@@ -20,14 +20,20 @@
                   (.setPassword "two-pass")))))
 
 (def ^:private dummy-repos
-  {"serv1" {:url "https://one.example.com"}
+  {;; duplicated with dummy-settings
+   "serv1" {:url "https://one.example.com"}
+   ;; duplicated with dummy-settings
    "serv2" {:url "https://two.example.com"}
+   ;; new to appear
    "serv3" {:url "https://three.example.com"
             :username "three-user"
             :password "three-pass"}
+   ;; new to appear
    "serv4" {:url "https://three.example.com"
             :username :env
-            :password :env/four}})
+            :password :env/four}
+   ;; should not be added because of missing username and password
+   "dummy" {:url "https://dummy.example.com"}})
 
 (def ^:private dummy-env
   {"LEIN_PASSWORD" "lein-pass"