Pass 2 hints (prev and next) to SortedCDPs.insert

[bingen]

Function insert in SortedCDPs uses 2 hints, but it’s called from BorrowerOperations and CDPManager with _prevId and _nextId being the same.
In particular, when _validInsertPosition is called, it’s always going to return false, except in the trivial case where the list is empty and the hint is zero.
It makes more sense that is called with different arguments for each hint for the call from openLoan (its signature needs to be changed too).

[danielattilasimon]

The middleware will need updating around this piece:

dev/packages/lib-ethers/src/EthersLiquity.ts

Lines 285 to 297 in 61a7ee9

	const approxHint = await this.hintHelpers.getApproxHint(
	collateralRatio.bigNumber,
	numberOfTrials
	);
	const [hint] = await this.sortedCDPs.findInsertPosition(
	collateralRatio.bigNumber,
	price.bigNumber,
	approxHint,
	approxHint
	);
	return hint;

As you can see it's currently picking the first element of the return tuple of findInsertPosition as hint, but we could just as well take both.

[danielattilasimon]

I recommend making this change after #94 to avoid conflicts.

[bingen]

Fixed in #228

[github-actions]

🎉 This issue has been resolved in version @liquity/lib-ethers-v1.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀