Break down approx hint search into multiple smaller calls #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to update tests and write new tests that exercise the new middleware code (somehow). |
danielattilasimon
force-pushed
the
find_hints_when_many_troves
branch
2 times, most recently
from
06cb564
to
8ca8be7
Compare
When the number of troves is huge, we might need more trials than possible on a provider like Infura (~4900 max trials) to get a good quality approx hint. Modify getApproxHint to make the search resumable, and do it in multiple rounds. Fixes #2.
Use chai-spies to substitute the real contracts, since it takes too long to create a million Troves for testing.
danielattilasimon
force-pushed
the
find_hints_when_many_troves
branch
from
e960cb3
to
c5b38ef
Compare
danielattilasimon
requested review from
RickGriff and
bingen
and removed request for
RickGriff and
bingen
danielattilasimon
changed the title
bingen
approved these changes
Nov 17, 2020
| @@ -5,6 +5,8 @@ const th = testHelpers.TestHelper | |||
| const dec = th.dec | |||
| const moneyVals = testHelpers.MoneyValues | |||
|
|
|||
| let latestRandomSeed = 31337 | |||
|
🎉 This PR is included in version @liquity/lib-ethers-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of troves is huge, we might need more trials than
possible on a provider like Infura (~4900 max trials) to get a
good quality approx hint.
Modify getApproxHint to make the search resumable, and do it in
multiple rounds.
Fixes #2.