Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hostvalidator): support full urls for host #88

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

lirantal
Copy link
Owner

Description

Support URLs provided for the host parameter by parsing them for the actual host.

  • Fix breaking tests due to changes in host validator
  • Attempt to parse a URL in order to capture the host for it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@lirantal lirantal self-assigned this Apr 30, 2020
@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #88 into master will decrease coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #88      +/-   ##
===========================================
- Coverage   100.00%   99.57%   -0.43%     
===========================================
  Files            8       11       +3     
  Lines          161      235      +74     
  Branches        33       40       +7     
===========================================
+ Hits           161      234      +73     
- Misses           0        1       +1     
Impacted Files Coverage Δ
...s/lockfile-lint-api/src/validators/ValidateHost.js 100.00% <100.00%> (ø)
packages/lockfile-lint/src/config.js 100.00% <0.00%> (ø)
packages/lockfile-lint/src/main.js 95.65% <0.00%> (ø)
packages/lockfile-lint/src/validators/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff6eb8...f6f6fae. Read the comment docs.

@lirantal lirantal added the bug Something isn't working label Apr 30, 2020
@lirantal lirantal merged commit d0002e7 into master Apr 30, 2020
@lirantal lirantal deleted the fix/support-url-for-host branch July 7, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants