Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: show custom request headers if they exist #78

Merged
merged 2 commits into from
Aug 4, 2018

Conversation

zilong-thu
Copy link
Contributor

@zilong-thu zilong-thu commented Jul 24, 2018

I think it's useful if Network panel could tell us the request headers we set with XMLHttpRequest.prototype.setRequestHeader method. So this feature is added in this pull request.

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #78 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   74.22%   74.31%   +0.08%     
==========================================
  Files          34       34              
  Lines        2603     2612       +9     
==========================================
+ Hits         1932     1941       +9     
  Misses        671      671
Impacted Files Coverage Δ
src/Network/XhrRequest.js 94.44% <ø> (ø) ⬆️
src/Network/Network.js 81.9% <100%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a87e71...83069db. Read the comment docs.

@zilong-thu zilong-thu force-pushed the feature/network/request-headers branch from 3f64aca to 83069db Compare July 24, 2018 09:17
@surunzi surunzi merged commit 71a3f95 into liriliri:master Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants