Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: show custom request headers if they exist #78

Merged
merged 2 commits into from
Aug 4, 2018
Merged

feature: show custom request headers if they exist #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d0d8cd
feature: show custom request headers if exist
zilong-thu Jul 24, 2018
83069db
fix: key and val might be undefined
zilong-thu Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/Network/Network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ export default class Network extends Tool {
let winXhrProto = window.XMLHttpRequest.prototype

let origSend = (this._origSend = winXhrProto.send),
origOpen = (this._origOpen = winXhrProto.open)
origOpen = (this._origOpen = winXhrProto.open),
origSetRequestHeader = (this._origSetRequestHeader =
winXhrProto.setRequestHeader)

let self = this

Expand Down Expand Up @@ -76,6 +78,20 @@ export default class Network extends Tool {

origSend.apply(this, arguments)
}

winXhrProto.setRequestHeader = function() {
let req = this.erudaRequest
if (!req._headers) {
req._headers = {}
}
let key = arguments[0]
let val = arguments[1]
if (key && val) {
req._headers[key] = val
}

origSetRequestHeader.apply(this, arguments)
}
}
restoreXhr() {
let winXhrProto = window.XMLHttpRequest.prototype
Expand Down Expand Up @@ -119,6 +135,7 @@ export default class Network extends Tool {
startTime: now(),
time: 0,
resHeaders: {},
reqHeaders: {},
resTxt: '',
done: false
})
Expand Down Expand Up @@ -161,7 +178,8 @@ export default class Network extends Tool {
resTxt: data.resTxt,
type: data.type,
subType: data.subType,
resHeaders: data.resHeaders
resHeaders: data.resHeaders,
reqHeaders: data.reqHeaders
})
})
.on('click', '.eruda-clear-request', () => this.clear())
Expand Down
3 changes: 2 additions & 1 deletion src/Network/XhrRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export default class XhrRequest extends Emitter {
subType: type.subType,
size: getSize(xhr, true, this._url),
time: now(),
resHeaders: getHeaders(xhr)
resHeaders: getHeaders(xhr),
reqHeaders: (xhr.erudaRequest && xhr.erudaRequest._headers) || null
})
}
handleDone() {
Expand Down
1 change: 1 addition & 0 deletions src/Sources/Sources.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
td {
font-size: $font-size-s;
padding: 5px 10px;
word-break: break-all;
}
.key {
white-space: nowrap;
Expand Down
17 changes: 17 additions & 0 deletions src/Sources/http.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,23 @@
<pre class="eruda-data">{{data}}</pre>
{{/if}}
<div class="eruda-section">
<h2>Request Headers</h2>
<table class="eruda-headers">
<tbody>
{{#if reqHeaders}}
{{#each reqHeaders}}
<tr>
<td class="eruda-key">{{@key}}</td>
<td>{{.}}</td>
</tr>
{{/each}}
{{else}}
<tr>
<td>Empty</td>
</tr>
{{/if}}
</tbody>
</table>
<h2>Response Headers</h2>
<table class="eruda-headers">
<tbody>
Expand Down