Preserve selection state when password visibility is toggled #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems here: - Setting the input type resets the selection indices. We have to preserve and re-set them ourself. - Letting the TextView respond itself to clicks on MotionEvent.DOWN on the eye meant it was registering a click on the text field, which moved the cursor to the end. We probably need more sophisticated touch handling on the eye in general.
This was referenced Aug 14, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems here:
and re-set them ourself.
eye meant it was registering a click on the text field, which moved the cursor
to the end. We probably need more sophisticated touch handling on the eye
in general.