Skip to content

Commit

Permalink
Clarify submodules in the git readme and improve standard lib finding
Browse files Browse the repository at this point in the history
  • Loading branch information
Scott MacVicar committed Feb 20, 2010
1 parent 2fd5ef4 commit df70a23
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 13 additions & 1 deletion CMake/HPHPFindLibs.cmake
Expand Up @@ -132,11 +132,23 @@ FIND_LIBRARY(ONIG_LIB onig)

FIND_LIBRARY (CAP_LIB cap)

# potentially make it look in a different directory for the google apps
if (CAP_LIB STREQUAL "CAP_LIB-NOTFOUND")
message(FATAL_ERROR "You need to install libcap")
endif()

# potentially make it look in a different directory for the google tools
FIND_LIBRARY (BFD_LIB bfd)
FIND_LIBRARY (BINUTIL_LIB iberty)
FIND_LIBRARY (DL_LIB dl)

if (BFD_LIB STREQUAL "BFD_LIB-NOTFOUND")
message(FATAL_ERROR "You need to install binutils")
endif()

if (BINUTIL_LIB STREQUAL "BINUTIL_LIB-NOTFOUND")
message(FATAL_ERROR "You need to install binutils")
endif()


include_directories(${HPHP_HOME}/src)
include_directories(${HPHP_HOME}/src/lib/system/gen)
Expand Down
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -43,6 +43,8 @@ To build HipHop use the following
cd /home/user/dev
git clone git://github.com/facebook/hiphop-php.git
cd hiphop-php
git submodule init
git submodule update
export HPHP_HOME=`pwd`
export HPHP_LIB=`pwd`/bin
cmake .
Expand Down

0 comments on commit df70a23

Please sign in to comment.