Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

'cmd-enter' keybinding does not work on Windows or Linux #7

Closed
kindohm opened this issue Feb 26, 2015 · 6 comments · May be fixed by kindohm/atom-tidal#1
Closed

'cmd-enter' keybinding does not work on Windows or Linux #7

kindohm opened this issue Feb 26, 2015 · 6 comments · May be fixed by kindohm/atom-tidal#1

Comments

@kindohm
Copy link
Contributor

kindohm commented Feb 26, 2015

The cmd-enter keybinding to evaluate multiple lines does not work on Windows or Linux because there is no cmd key.

An additional ctrl-enter keybinding should work. Any concerns about adding this? I have a fix ready to go.

@lisongx
Copy link
Owner

lisongx commented Feb 27, 2015

look good to me, not sure atom has os specfic keybinding setting, but have both key should be fine on mac

@yaxu

@yaxu
Copy link

yaxu commented Feb 27, 2015

I think the emacs plugin uses alt-enter, it might be nice to standardise.

@yaxu
Copy link

yaxu commented Feb 27, 2015

I tell a lie, it's ctrl-enter in emacs as well!

@lisongx
Copy link
Owner

lisongx commented Feb 27, 2015

@yaxu @kindohm
let's add a ctrl-enter binding!

@kindohm
Copy link
Contributor Author

kindohm commented Feb 27, 2015

I'll send the PR soon
On Feb 27, 2015 7:27 AM, "Sean Lee" notifications@github.com wrote:

@yaxu https://github.com/yaxu @kindohm https://github.com/kindohm
let's add a ctrl-enter binding!


Reply to this email directly or view it on GitHub
#7 (comment).

@kindohm
Copy link
Contributor Author

kindohm commented Feb 27, 2015

submitted a pull request: #8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants