Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revise] change the default directory to save Natural Earth data #1190

Closed
5 tasks
lisphilar opened this issue Sep 11, 2022 · 1 comment · Fixed by #1191
Closed
5 tasks

[Revise] change the default directory to save Natural Earth data #1190

lisphilar opened this issue Sep 11, 2022 · 1 comment · Fixed by #1191
Labels
enhancement New feature or request

Comments

@lisphilar
Copy link
Owner

lisphilar commented Sep 11, 2022

Summary of this new feature

As discussed in #1173, Natural Earth published under Public Domain, will be included in covsirphy as geopandas does.

  • Add a script of downloading/updating the dataset to stable version publish workflow
  • Save the file in covsirphy/gis/natural_earth directory with README.md (to explain the data source)
  • Ensure covsirphy to include the dataset with pyproject.toml (using "include" option?)
  • covsirphy.gis.geometry._Geometry._natural_earth() will read the saved files internally (with relative path from covsirphy directory?)
  • Explain the workflow and data source in documentation

CovsirPhy version I used: 2.26.1

@lisphilar lisphilar added the enhancement New feature or request label Sep 11, 2022
@lisphilar lisphilar added this to the Release v2.26.2 milestone Sep 11, 2022
@lisphilar
Copy link
Owner Author

Because the dataset of the data source will be updated irregularly, the dataset will not be included in CovsirPhy. As a quick solution, the directory to save the files will be changed to "covsirphy/gis/Natural_Earth" directory.

@lisphilar lisphilar changed the title [New] include Natural Earth data in covsirphy library [New] change the default directory to save Natural Earth data Sep 11, 2022
lisphilar added a commit that referenced this issue Sep 11, 2022
@lisphilar lisphilar mentioned this issue Sep 11, 2022
lisphilar added a commit that referenced this issue Sep 11, 2022
@lisphilar lisphilar changed the title [New] change the default directory to save Natural Earth data [Revise] change the default directory to save Natural Earth data Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant