Issue1190

[lisphilar]

Related issues

#1173, #1190

What was changed

• close [Revise] change the default directory to save Natural Earth data #1190

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics	Before	After	Change
Complexity	1.95 ⭐	1.95 ⭐	0.00
Method Length	94.37 🙂	94.58 🙂	0.21 👎
Working memory	8.33 🙂	8.31 🙂	-0.02 👍
Quality	68.46% 🙂	68.47% 🙂	0.01% 👍

Other metrics	Before	After	Change
Lines	967	968	1

Changed files	Quality Before	Quality After	Quality Change
covsirphy/engineering/engineer.py	69.21% 🙂	69.26% 🙂	0.05% 👍
covsirphy/gis/gis.py	61.60% 🙂	61.56% 🙂	-0.04% 👎
covsirphy/util/filer.py	80.49% ⭐	80.42% ⭐	-0.07% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
covsirphy/gis/gis.py	GIS.subset	6 ⭐	220 ⛔	11 😞	49.17% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/engineering/engineer.py	DataEngineer.subset	3 ⭐	272 ⛔	10 😞	51.27% 🙂	Try splitting into smaller methods. Extract out complex expressions
covsirphy/gis/gis.py	GIS.to_geopandas	5 ⭐	196 😞	11 😞	51.85% 🙂	Try splitting into smaller methods. Extract out complex expressions
covsirphy/gis/gis.py	GIS.layer	6 ⭐	206 ⛔	10 😞	52.03% 🙂	Try splitting into smaller methods. Extract out complex expressions
covsirphy/engineering/engineer.py	DataEngineer.sub	1 ⭐	171 😞	10 😞	59.84% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1191 (ae91614) into master (8bb4766) will increase coverage by 0.05%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
+ Coverage   88.85%   88.91%   +0.05%     
==========================================
  Files          46       46              
  Lines        3364     3364              
==========================================
+ Hits         2989     2991       +2     
+ Misses        375      373       -2     

Impacted Files	Coverage Δ
covsirphy/science/ode_scenario.py	67.22% <66.66%> (+0.69%)	⬆️
covsirphy/__version__.py	100.00% <100.00%> (ø)
covsirphy/engineering/engineer.py	100.00% <100.00%> (ø)
covsirphy/gis/gis.py	100.00% <100.00%> (ø)
covsirphy/util/filer.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.