-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hangs on closing connection if nsqd socket is closed during message sending #33
Comments
I've researched it a bit, as asyncio docs says about
Also, However, in library code any exception in Lines 122 to 128 in cb4c722
And code intended to unhang command located below is never reached Lines 130 to 133 in cb4c722
|
Suggested fix at #34 |
…osing-connection-if-nsqd-socket-is-closed-during-message-sending Catch `writer.wait_closed()` exception to avoid command hanging. #33
Environment Versions
Python 3.8.5
0.0.17
Originally was reproduced in
kubectl
which closes pipe on pod deletion.Steps to reproduce
nsqd
container$ docker run -it -p 4150:4150 nsqio/nsq sh
nsqd
inside container:# nsqd
nsqd
in container using^c
(to simulate broken pipe error)Expected result
Script should raise and error and fail (since only one reconnection is possible, and pipe is already closed)
Actual result
Traceback after stopping with
^c
The text was updated successfully, but these errors were encountered: