Catch writer.wait_closed()
exception to avoid command hanging. #33
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
As asyncio docs says about
StreamWriter.write
method:Also,
wait_closed
is writing data left in buffer before exitingHowever, in library code any exception in
wait_closed
is ignored:ansq/ansq/tcp/connection.py
Lines 122 to 128 in cb4c722
And code intended to unhang command located below is never reached
ansq/ansq/tcp/connection.py
Lines 130 to 133 in cb4c722