[lit-html] disabled shadydom nopatch in node dev build (#3526)

lit · Jan 11, 2023 · 65e5665 · 65e5665
1 parent 214f61c
commit 65e5665
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 4 deletions.
diff --git a/.changeset/friendly-papayas-glow.md b/.changeset/friendly-papayas-glow.md
@@ -0,0 +1,6 @@
+---
+'lit': patch
+'lit-html': patch
+---
+
+Disable ShadyDOM noPatch in Node dev build. This fixes the issue of throwing due to undefined `window`.
diff --git a/packages/lit-html/package.json b/packages/lit-html/package.json
@@ -287,7 +287,8 @@
     "test": "wireit",
     "test:dev": "wireit",
     "test:prod": "wireit",
-    "test:node": "wireit"
+    "test:node": "wireit",
+    "test:node-dev": "wireit"
   },
   "files": [
     "/async-directive.{d.ts,d.ts.map,js,js.map}",
@@ -408,6 +409,7 @@
         "test:dev",
         "test:prod",
         "test:node",
+        "test:node-dev",
         "check-version"
       ]
     },
@@ -449,6 +451,15 @@
       ],
       "files": [],
       "output": []
+    },
+    "test:node-dev": {
+      "command": "node --conditions=development development/test/node-imports.js",
+      "dependencies": [
+        "build:ts",
+        "build:rollup"
+      ],
+      "files": [],
+      "output": []
     }
   },
   "dependencies": {

diff --git a/packages/lit/package.json b/packages/lit/package.json
@@ -183,7 +183,8 @@
     "test": "wireit",
     "test:dev": "wireit",
     "test:prod": "wireit",
-    "test:node": "wireit"
+    "test:node": "wireit",
+    "test:node-dev": "wireit"
   },
   "wireit": {
     "build": {
@@ -274,7 +275,8 @@
       "dependencies": [
         "test:dev",
         "test:prod",
-        "test:node"
+        "test:node",
+        "test:node-dev"
       ]
     },
     "test:dev": {
@@ -318,6 +320,15 @@
       ],
       "files": [],
       "output": []
+    },
+    "test:node-dev": {
+      "command": "node --conditions=development development/test/node-imports.js",
+      "dependencies": [
+        "build:ts",
+        "build:rollup"
+      ],
+      "files": [],
+      "output": []
     }
   },
   "files": [

diff --git a/packages/reactive-element/package.json b/packages/reactive-element/package.json
@@ -165,7 +165,8 @@
     "test": "wireit",
     "test:dev": "wireit",
     "test:prod": "wireit",
-    "test:node": "wireit"
+    "test:node": "wireit",
+    "test:node-dev": "wireit"
   },
   "wireit": {
     "build": {
@@ -266,6 +267,7 @@
         "test:dev",
         "test:prod",
         "test:node",
+        "test:node-dev",
         "check-version"
       ]
     },
@@ -308,6 +310,15 @@
       ],
       "files": [],
       "output": []
+    },
+    "test:node-dev": {
+      "command": "node --conditions=development development/test/node-imports.js",
+      "dependencies": [
+        "build:ts",
+        "build:rollup"
+      ],
+      "files": [],
+      "output": []
     }
   },
   "files": [

diff --git a/rollup-common.js b/rollup-common.js
@@ -530,6 +530,8 @@ export function litProdConfig({
                   // i.e. using globalThis instead of window, and shimming APIs
                   // needed for Lit bootup.
                   'const NODE_MODE = false': 'const NODE_MODE = true',
+                  'const ENABLE_SHADYDOM_NOPATCH = true':
+                    'const ENABLE_SHADYDOM_NOPATCH = false',
                 },
               }),
               ...injectNodeDomShimIntoReactiveElement,