[ReactiveElement] Add scheduleUpdate method
#2091
Assignees
Milestone
Comments
sorvell
pushed a commit
that referenced
this issue
Aug 26, 2021
Fixes #2091. Fixes an issue where `performUpdate` was doing double duty as (1) make the element complete a pending update synchronously and (2) override to control update timing. Here `scheduleUpdate()` is added to satisfy (2), reserving (1) for `performUpdate()`. Since by default `scheduleUpdate()` just returns the value of `performUpdate()` this should not break any existing code. However, the docs are updated to recommend that for scheduling `scheduleUpdate()` be implemented in favor of `performUpdate()`.
sorvell
pushed a commit
that referenced
this issue
Aug 27, 2021
Fixes #2091. Fixes an issue where `performUpdate` was doing double duty as (1) make the element complete a pending update synchronously and (2) override to control update timing. Here `scheduleUpdate()` is added to satisfy (2), reserving (1) for `performUpdate()`. Since by default `scheduleUpdate()` just returns the value of `performUpdate()` this should not break any existing code. However, the docs are updated to recommend that for scheduling `scheduleUpdate()` be implemented in favor of `performUpdate()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have an issue where
performUpdateis doing double duty. Users can override it to schedule updates, but we also recommend that users can call it to make an update synchronous. To resolve this, we'll addscheduleUpdateand recommend users override that for scheduling and useperformUpdateto make the update "go" synchronously.We also need to update the docs on lit.dev to reflect this change.
The text was updated successfully, but these errors were encountered: