Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReactiveElement] Adds scheduleUpdate() #2097

Merged
merged 4 commits into from
Aug 27, 2021
Merged

[ReactiveElement] Adds scheduleUpdate() #2097

merged 4 commits into from
Aug 27, 2021

Commits on Aug 26, 2021

  1. [ReactiveElement] Adds scheduleUpdate()

    Fixes #2091. Fixes an issue where `performUpdate` was doing double duty as (1) make the element complete a pending update synchronously and (2) override to control update timing. Here `scheduleUpdate()` is added to satisfy (2), reserving (1) for `performUpdate()`. Since  by default `scheduleUpdate()` just returns the value of `performUpdate()` this should not break any existing code. However, the docs are updated to recommend that for scheduling `scheduleUpdate()` be implemented in favor of `performUpdate()`.
    Steven Orvell committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    0e0903f View commit details
    Browse the repository at this point in the history
  2. Add changeset.

    Steven Orvell committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    7e6e2d6 View commit details
    Browse the repository at this point in the history
  3. Address review feedback.

    Steven Orvell committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    9d9bc67 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Update packages/reactive-element/src/reactive-element.ts

    Co-authored-by: Justin Fagnani <justinfagnani@google.com>
    Steve Orvell and justinfagnani committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b2beae2 View commit details
    Browse the repository at this point in the history