You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Babel tests were disabled because Babel hadn't implemented metadata and the had some bugs that we triggered during tests. This PR updates Babel and enables the tests.
We don't strictly need the tests through multiple compilers if the compilers are spec compliant, but the compile author have wanted to see real-world usage work since decorators are a complicated feature, and this is a good way to catch regressions. When decorators are shipping natively, we could reduce our test load.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Babel tests were disabled because Babel hadn't implemented metadata and the had some bugs that we triggered during tests. This PR updates Babel and enables the tests.
The esbuild tests are new, since esbuild just shipped decorator are metadata support.
We don't strictly need the tests through multiple compilers if the compilers are spec compliant, but the compile author have wanted to see real-world usage work since decorators are a complicated feature, and this is a good way to catch regressions. When decorators are shipping natively, we could reduce our test load.