Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Babel decorator tests and add esbuild tests #4648

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

justinfagnani
Copy link
Collaborator

The Babel tests were disabled because Babel hadn't implemented metadata and the had some bugs that we triggered during tests. This PR updates Babel and enables the tests.

The esbuild tests are new, since esbuild just shipped decorator are metadata support.

We don't strictly need the tests through multiple compilers if the compilers are spec compliant, but the compile author have wanted to see real-world usage work since decorators are a complicated feature, and this is a good way to catch regressions. When decorators are shipping natively, we could reduce our test load.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: cda1a9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 16, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +4% (-0.43ms - +0.46ms)
    this-change vs tip-of-tree

render

  • this-change: 46.93ms - 49.54ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +7% (-0.10ms - +1.23ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.74ms - +0.47ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.48ms - +0.71ms)
    this-change vs tip-of-tree

update

  • this-change: 498.43ms - 510.47ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +11% (-0.80ms - +4.36ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.31ms - +2.06ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-10.01ms - +3.52ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 507.59ms - 514.83ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-12.52ms - +7.71ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
46.93ms - 49.54ms-

update

VersionAvg timevs
498.43ms - 510.47ms-

update-reflect

VersionAvg timevs
507.59ms - 514.83ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.52ms - 19.50ms-unsure 🔍
-1% - +7%
-0.10ms - +1.23ms
unsure 🔍
-0% - +7%
-0.05ms - +1.23ms
tip-of-tree
tip-of-tree
18.00ms - 18.89msunsure 🔍
-6% - +0%
-1.23ms - +0.10ms
-unsure 🔍
-3% - +3%
-0.59ms - +0.64ms
previous-release
previous-release
18.00ms - 18.84msunsure 🔍
-6% - +0%
-1.23ms - +0.05ms
unsure 🔍
-3% - +3%
-0.64ms - +0.59ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
38.93ms - 42.59ms-unsure 🔍
-2% - +11%
-0.80ms - +4.36ms
slower ❌
2% - 14%
0.74ms - 5.28ms
tip-of-tree
tip-of-tree
37.17ms - 40.79msunsure 🔍
-11% - +2%
-4.36ms - +0.80ms
-unsure 🔍
-3% - +9%
-1.02ms - +3.48ms
previous-release
previous-release
36.41ms - 39.08msfaster ✔
2% - 13%
0.74ms - 5.28ms
unsure 🔍
-9% - +2%
-3.48ms - +1.02ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.64ms - 11.35ms-unsure 🔍
-4% - +4%
-0.43ms - +0.46ms
unsure 🔍
-1% - +8%
-0.12ms - +0.83ms
tip-of-tree
tip-of-tree
10.71ms - 11.25msunsure 🔍
-4% - +4%
-0.46ms - +0.43ms
-unsure 🔍
-1% - +7%
-0.08ms - +0.76ms
previous-release
previous-release
10.32ms - 10.96msunsure 🔍
-7% - +1%
-0.83ms - +0.12ms
unsure 🔍
-7% - +1%
-0.76ms - +0.08ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.67ms - 34.28ms-unsure 🔍
-2% - +1%
-0.74ms - +0.47ms
unsure 🔍
-1% - +1%
-0.40ms - +0.45ms
tip-of-tree
tip-of-tree
33.59ms - 34.63msunsure 🔍
-1% - +2%
-0.47ms - +0.74ms
-unsure 🔍
-1% - +2%
-0.44ms - +0.77ms
previous-release
previous-release
33.65ms - 34.25msunsure 🔍
-1% - +1%
-0.45ms - +0.40ms
unsure 🔍
-2% - +1%
-0.77ms - +0.44ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
72.83ms - 75.17ms-unsure 🔍
-2% - +3%
-1.31ms - +2.06ms
unsure 🔍
-3% - +2%
-1.86ms - +1.56ms
tip-of-tree
tip-of-tree
72.41ms - 74.84msunsure 🔍
-3% - +2%
-2.06ms - +1.31ms
-unsure 🔍
-3% - +2%
-2.27ms - +1.22ms
previous-release
previous-release
72.90ms - 75.40msunsure 🔍
-2% - +3%
-1.56ms - +1.86ms
unsure 🔍
-2% - +3%
-1.22ms - +2.27ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
32.14ms - 33.00ms-unsure 🔍
-1% - +2%
-0.48ms - +0.71ms
unsure 🔍
-1% - +3%
-0.34ms - +0.86ms
tip-of-tree
tip-of-tree
32.05ms - 32.87msunsure 🔍
-2% - +1%
-0.71ms - +0.48ms
-unsure 🔍
-1% - +2%
-0.44ms - +0.73ms
previous-release
previous-release
31.89ms - 32.73msunsure 🔍
-3% - +1%
-0.86ms - +0.34ms
unsure 🔍
-2% - +1%
-0.73ms - +0.44ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
515.54ms - 525.39ms-unsure 🔍
-2% - +1%
-10.01ms - +3.52ms
unsure 🔍
-2% - +0%
-11.97ms - +2.30ms
tip-of-tree
tip-of-tree
519.07ms - 528.36msunsure 🔍
-1% - +2%
-3.52ms - +10.01ms
-unsure 🔍
-2% - +1%
-8.54ms - +5.35ms
previous-release
previous-release
520.14ms - 530.47msunsure 🔍
-0% - +2%
-2.30ms - +11.97ms
unsure 🔍
-1% - +2%
-5.35ms - +8.54ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
548.42ms - 562.12ms-unsure 🔍
-2% - +1%
-12.52ms - +7.71ms
unsure 🔍
-2% - +1%
-12.13ms - +8.16ms
tip-of-tree
tip-of-tree
550.24ms - 565.12msunsure 🔍
-1% - +2%
-7.71ms - +12.52ms
-unsure 🔍
-2% - +2%
-10.13ms - +10.97ms
previous-release
previous-release
549.77ms - 564.74msunsure 🔍
-1% - +2%
-8.16ms - +12.13ms
unsure 🔍
-2% - +2%
-10.97ms - +10.13ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@justinfagnani justinfagnani merged commit 2633e76 into main May 17, 2024
9 checks passed
@justinfagnani justinfagnani deleted the babel-tests branch May 17, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants