Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC process and template #1

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Add RFC process and template #1

merged 5 commits into from
Aug 10, 2022

Conversation

justinfagnani
Copy link
Contributor

Before this PR is merged the contents of 0001-rfc-process.md will be copied to the README.

Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

rfcs/0000-rfc-template.md Outdated Show resolved Hide resolved
rfcs/0000-rfc-template.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0000-rfc-template.md Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
justinfagnani and others added 2 commits July 26, 2022 12:16
Co-authored-by: Alexander Marks <aomarks@google.com>
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion on the template and a couple typos, otherwise LGTM!

rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0001-rfc-process.md Outdated Show resolved Hide resolved
rfcs/0000-rfc-template.md Show resolved Hide resolved
@justinfagnani justinfagnani merged commit 2a89a1d into main Aug 10, 2022
@justinfagnani justinfagnani deleted the rfc-process branch August 10, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants