Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.16.4 Crashing when I'm opening binary files #122

Closed
azb92 opened this issue Mar 20, 2021 · 2 comments
Closed

1.16.4 Crashing when I'm opening binary files #122

azb92 opened this issue Mar 20, 2021 · 2 comments
Labels
bug Something isn't working p:high

Comments

@azb92
Copy link

azb92 commented Mar 20, 2021 •
edited

Problem on Windows 10.
We had the same problem on version 1.16.2
@azb92 azb92 changed the title 1.16.4 Crashing when Iopen binary filses 1.16.4 Crashing when I'm opening binary files Mar 20, 2021
@franko franko added bug Something isn't working p:high labels Mar 20, 2021
franko added a commit that referenced this issue Mar 20, 2021
@franko
Revert "Remove unused data field in RenFont"
b33167c 
This reverts commit 461266e.

Related to github issue #122.

The void *data field is not used but the glyphset index can
someting be equal to -1 and the unused field prevent faulty
writes before the allocated struct.
@franko
Copy link
Member

franko commented Mar 20, 2021

Found the problem. It was a very subtle thing and unfortunately I forgot to test for binary files! My bad, I need to create another release now.

@franko
Copy link
Member

franko commented Mar 20, 2021

Ok I did a new release just for this problem!

@franko franko closed this as completed Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franko @azb92