Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp the size of the TreeView to a minimum of 0 #50

Closed
wants to merge 1 commit into from

Conversation

liquidev
Copy link
Collaborator

Fixes #44. I'm not sure if there's a more clean way of doing this, I scoured the RootView's code but couldn't find how the sizes of DocViews are exactly clamped, so I did this. Hopefully it's not too horrible!

@budRich
Copy link
Contributor

budRich commented Feb 20, 2021

I tested this and it works great. I also tried resizing it to 0 just to see that i was then able to grab the border, and that worked as well. @franko in contrary to myself actually knows Lua and can have a look this before its merged. But I think the solution looks really elegant, probably useful for other things as well.

@franko
Copy link
Member

franko commented Feb 20, 2021

Good, thank you but I already fixed in a less ad-hoc way. I was in a better position than you for that because I know the lite resize system and I modified it recently for the 1.16 release.

My fix also clamp the treeview resize on the other side!

@franko franko closed this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeView width is not clamped
3 participants