Fix the size and blurriness of the icon on OSX #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
instead of nesting preprocessor I think you could use |
Guldoman
reviewed
Sep 29, 2021
|
So many contributors involved for a line of code! Thank you for the fix. |
franko
pushed a commit
that referenced
this pull request
Oct 2, 2021
* Fix the size and blurriness of the icon on OSX * Don't nest ifndef * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #550
The icon is now using a size identical to other OSX app icons.
The blurriness was caused by using an SDL window icon, which is not required on OSX apps. Removing it fixed it.