Disable Wallet Mode for Litecoin #78
Conversation
|
The previous disablewallet branch was moved to
This is based largely on commits already in Bitcoin master with the exception of bitcoin#2901 which is not net merged. |
|
The previous disablewallet branch was moved to |
|
Backported GUI support for -disablewallet mode from bitcoin#3240 It was not a straightforward backport. It is possible that something in the GUI no longer works, so please test all features in the GUI with the wallet enabled. |
This commit decouples the pMiningKey initialization and shutdown from the RPC threads. `getwork` and `getblocktemplate` rely on pMiningKey, and can also be ran from the debug window in the UI even when the RPC server is not running. Solves issue bitcoin#2706. Conflicts: src/rpcmining.cpp
* Fix UpdateCoins() definition in main.h * Remove pwalletMain reference from BitcoinMiner(), as it is passed a wallet argument. Conflicts: src/main.h Rebased-from: 1894684
rather than a key. CreateNewBlockWithKey() helper is added to restore existing functionality, making this an equivalent-transformation change. Conflicts: src/miner.cpp src/miner.h Rebased-from: fcc32b7b9ce5bc310cbad677da7e7bca3a01459a
getblocktemplate only uses certain portions of the coinbase transaction, notably ignoring the coinbase TX output entirely. Use CreateNewBlock() rather than CreateNewBlockWithKey(), eliminating the needless key passing. Should be zero behavior changes.
Conflicts: src/miner.cpp src/miner.h Rebased-from: ad7d7cde5d30bcbfa7803c90daac7297b8a55e42
notably RPC. Conflicts: src/init.cpp src/rpcmining.cpp src/rpcwallet.cpp src/bitcoinrpc.cpp Rebased-from: 541a7fcd515a27ebaa3ae5f1a9a698dab3db6ead
Conflicts: src/rpcwallet.cpp Rebased-from: b878f6a92436e3facd700e2e10c04f541cd6421b
Rebased-from: 520cc05 Conflicts: src/init.cpp
Conflicts: src/init.cpp Rebased-from: 5d4f3a1
Rebased-from: 8121047b20f6486bf049e642c3e6ca61682ffdd9
|
Rebased on master-0.8 with no changes. Five commits were added to master-0.8 as they are simple, well tested and simple prerequisites to make merging disablewallet cleaner. The remaining commits have equivalents in Bitcoin master and should be compared to the upstream commits to make sure merge errors didn't add things by accident. Five commits added to master-0.8 were:
|
|
Merged |
disablewallet=1 allows litecoind to operate with the BDB wallet disabled. This is known to reduce the memory necessary to operate a relay-only node by between 40-200MB. Pool servers and p2pool nodes can also operate with the disablewallet=1 by setting their payout address to an arbitrary address managed elsewhere. This can enhance security of mining nodes.