Blocks rendering #268
Merged
Blocks rendering #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved display property based re-rendering from render_item_block::render to the top functions: place_float, place_inline and render_item_block_context::_render_content
* is_floats_holder function is renamed to is_block_formatting_context * All floating boxes related functions are moved to new class formatting_context * The class formatting_context was passed as argument to the render function * render function is now is wrapper for _render. The render function creates formatting_context when required
Also added element::children() method. Closes issue #27
* now ::before and ::after elements are created if content is not defined * styles ::before and ::after without other selectors are applied to the already created before/after elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.