Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node18 base image as runner #2152

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Use node18 base image as runner #2152

merged 2 commits into from
Sep 21, 2023

Conversation

Kailai-Wang
Copy link
Collaborator

Context

node:18-bookworm-slim is chosen for a compact runner image.

solves #2148

@Kailai-Wang Kailai-Wang self-assigned this Sep 21, 2023
@Kailai-Wang Kailai-Wang requested a review from a team September 21, 2023 21:14
kziemianek
kziemianek approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok 👍🏼

@Kailai-Wang Kailai-Wang merged commit 0500c2a into dev Sep 21, 2023
28 checks passed
@Kailai-Wang Kailai-Wang deleted the 2148-new-node-setup branch September 21, 2023 21:30
@Kailai-Wang Kailai-Wang linked an issue Sep 22, 2023 that may be closed by this pull request
Migrate nodejs instalation script in tee-worker docker image #2148
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kziemianek kziemianek kziemianek approved these changes

Assignees

@Kailai-Wang Kailai-Wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate nodejs instalation script in tee-worker docker image
2 participants
@Kailai-Wang @kziemianek