-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bean support for TokenAmountHolding VC #2770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, if we want to add COMBO we probably need to add another a separete bean_balance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @higherordertech ! Looks good
So i was tracking the logic,
To use NodeReal
for COMBO we have to make changes to
litentry-parachain/tee-worker/litentry/core/data-providers/src/nodereal_jsonrpc.rs
Line 67 in 7e45fbd
pub enum NoderealChain { |
and rest of the things in this file.
So we need to do the above changes for supporting COMBO.
* feat: add new web3 network combo * fix: support bean on combo * refactor: use combo instead of combo-mainnet
Attaching test evidence too:
Example generated VC:
|
With real endpoint:
|
…nt VC
Context
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable