Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bean token holding on combo mainnet #2771

Merged
merged 3 commits into from
May 29, 2024

Conversation

felixfaisal
Copy link
Member

This adds new web3network combo and supports holding amount calculation for bean.
I couldn't perform e2e test.

@Kailai-Wang
Copy link
Collaborator

Kailai-Wang commented May 29, 2024

Another thing is: we are adding new item to Web3Network, I assume this won't require any state migration, right? (meaning the stored user IDGraph could still be retrieved after this upgrade)

@Kailai-Wang Kailai-Wang merged commit 129bdbf into P-822-BEAN-bsc-holding-amount May 29, 2024
@Kailai-Wang Kailai-Wang deleted the fx-bean-combo branch May 29, 2024 17:36
Kailai-Wang added a commit that referenced this pull request May 29, 2024
* feat: P-822 added web3 token BEAN on bsc network for TokenHoldingAmount VC

* feat: support bean token holding on combo mainnet (#2771)

* feat: add new web3 network combo

* fix: support bean on combo

* refactor: use combo instead of combo-mainnet

* use ws locally

* bump jsonschema version

---------

Co-authored-by: higherordertech <higherordertech>
Co-authored-by: Faisal Ahmed <42486737+felixfaisal@users.noreply.github.com>
Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants