Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tools::stripslashes() #2

Closed
wants to merge 2 commits into from
Closed

Fix Tools::stripslashes() #2

wants to merge 2 commits into from

Conversation

MathiasReker
Copy link
Contributor

The use of function stripslashes() is forbidden; use Tools::stripslashes() instead

The use of function stripslashes() is forbidden; use Tools::stripslashes() instead
@litespeedtech
Copy link
Owner

Hi, Mreker,
I have run with validator too and knew this complaint. But if you read the code for Tools::stripslashes, the wrapper will behave differently than direct call. And for the purpose of our use: remove slashes from json encoded javascript which has esi:include, we have to use the original function. I have rewrite many other code to avoid validator complain for using Tools wrapper. But this one I cannot. Tools wrapper is mainly for requests processing from outside, while LSCPS is internally injection of esi:include and esi:inline, that enforcement does not apply to our case.
Therefore, I have to reject your pull request.
Thanks and hope you can help in other ways.
Lauren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants