-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: relationship loader api #192
Conversation
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, those aside, this PR is loaded
Co-authored-by: Alc-Alc <45509143+Alc-Alc@users.noreply.github.com> Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Co-authored-by: Alc-Alc <45509143+Alc-Alc@users.noreply.github.com> Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments on the things I changed in base.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet done with the full thing but there's one major issue I see
* Fix loader_options * Fix execution_options * Remove unused params
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/192 |
Description
Closes