-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Improve warning message for ambiguous defaults #3372
Labels
Bug 🐛
This is something that is not working as expected
Enhancement
This is a new feature or request
Comments
JacobCoffee
added
Bug 🐛
This is something that is not working as expected
Enhancement
This is a new feature or request
labels
Apr 10, 2024
peterschutt
changed the title
Bug / Enhancement:
Bug / Enhancement: Improve warning message for ambiguous defaults
Apr 11, 2024
peterschutt
changed the title
Bug / Enhancement: Improve warning message for ambiguous defaults
Bug: Improve warning message for ambiguous defaults
Apr 11, 2024
peterschutt
added a commit
that referenced
this issue
Apr 12, 2024
We now only issue a single warning for the case where a default value is supplied via `Parameter()` and not via a regular signature default. Closes #3372
peterschutt
added a commit
that referenced
this issue
Apr 12, 2024
We now only issue a single warning for the case where a default value is supplied via `Parameter()` and not via a regular signature default. Closes #3372
peterschutt
added a commit
that referenced
this issue
Apr 12, 2024
We now only issue a single warning for the case where a default value is supplied via `Parameter()` and not via a regular signature default. Closes #3372
peterschutt
added a commit
that referenced
this issue
Apr 12, 2024
We now only issue a single warning for the case where a default value is supplied via `Parameter()` and not via a regular signature default. Closes #3372
This issue has been closed in #3378. The change will be included in the upcoming patch release. |
peterschutt
added a commit
that referenced
this issue
May 1, 2024
peterschutt
added a commit
that referenced
this issue
May 2, 2024
A fix for this issue has been released in v2.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug 🐛
This is something that is not working as expected
Enhancement
This is a new feature or request
Description
We should enhance the warning messages generated from #3280 in 2.8.
As a user just now upgrading and hitting this, across probably ~40 instances of that warning, this isn't terribly helpful:
URL to code causing the issue
No response
MCVE
No response
Steps to reproduce
Screenshots
"![SCREENSHOT_DESCRIPTION](SCREENSHOT_LINK.png)"
Logs
No response
Litestar Version
2.8
Platform
Note
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard
The text was updated successfully, but these errors were encountered: