fix: Ambiguous default warning for no signature default #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now only issue a single warning for the case where a default value is supplied via `Parameter()` and not via a regular signature default. Closes #3372
peterschutt
force-pushed
the
3372-ambig-default-warning
branch
from
f7c1207
to
f399608
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3378 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 323 323
Lines 14777 14778 +1
Branches 2347 2347
=======================================
+ Hits 14523 14524 +1
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3378 |
guacs
approved these changes
Apr 12, 2024
4 tasks
peterschutt
added a commit
that referenced
this pull request
May 1, 2024
peterschutt
added a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now only issue a single warning for the case where a default value is supplied via
Parameter()and not via a regular signature default.Closes #3372
Description
Closes