Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlalchemy): extend SQLAlchemy Plugin to include Alembic (Sourcery refactored) #2097

Closed
wants to merge 13 commits into from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Jul 30, 2023

Pull Request #2095 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/litestar-org/litestar pull/2095/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested review from a team as code owners July 30, 2023 18:55
@sourcery-ai sourcery-ai bot added the build-ignore This issue should skip builds label Jul 30, 2023
@sourcery-ai sourcery-ai bot requested a review from cofin July 30, 2023 18:55
@github-actions
Copy link

github-actions bot commented Jul 30, 2023

Qodana Community for Python

14 new problems were found

Inspection name Severity Problems
Accessing a protected member of a class or a module ◽️ Notice 5
Shadowing names from outer scopes ◽️ Notice 4
Class has no init method ◽️ Notice 3
Method is not declared static ◽️ Notice 1
Unused local symbols ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@cofin
Copy link
Member

cofin commented Jul 30, 2023

@JacobCoffee shouldn't this be configured to merge into the PR instead of main?

@JacobCoffee
Copy link
Member

JacobCoffee commented Jul 30, 2023

@cofin if it is a branch off of the main repo yes, but for some reason Sourcery cannot merge fork branches.

Maybe sourcery-ai/sourcery#375 can solve this, but I am not sure it is possible with GitHub apps

@cofin
Copy link
Member

cofin commented Jul 31, 2023

Closing this for now.

@cofin cofin closed this Jul 31, 2023
@cofin cofin deleted the sourcery/pull-2095 branch July 31, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-ignore This issue should skip builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants