feat!: Make route handlers functional decorators #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/handlers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #3436 +/- ##
=======================================
Coverage 97.98% 97.99%
=======================================
Files 326 326
Lines 14566 14559 -7
Branches 2314 2306 -8
=======================================
- Hits 14273 14267 -6
Misses 154 154
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
area/docs
provinzkraut
force-pushed
the
route-handler-decorators
branch
from
98bf1ab
to
48ab468
Compare
github-actions
bot
added
area/ci
Co-authored-by: Jacob Coffee <jacob@z7x.org>
Co-authored-by: Peter Schutt <peter.github@proton.me> Co-authored-by: Jacob Coffee <jacob@z7x.org>
provinzkraut
force-pushed
the
route-handler-decorators
branch
from
6847ae6
to
487447b
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3436 |
provinzkraut
added a commit
that referenced
this pull request
May 26, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jun 15, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jun 16, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jun 21, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jul 21, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Aug 25, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Aug 27, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Aug 28, 2024
* make route handlers functional decorators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make route handler decorators functional decorators.
This gets rids of the
__call__method having to mutate internal state and lets us clean up things a bit.It also makes for a nicer syntax and improved type/runtime checking of the handler classes, because they can now receive a
fnas a required keyword argument, which gets rid of theHandlerClass("/")(handler_fn)pattern.