Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export starlite cookie to header and use it in CSRF middleware and OpenAPI response #382

Merged
merged 3 commits into from Aug 20, 2022
Merged

Export starlite cookie to header and use it in CSRF middleware and OpenAPI response #382

merged 3 commits into from Aug 20, 2022

Conversation

seladb
Copy link
Contributor

@seladb seladb commented Aug 20, 2022

Changes

  • Add Cookie.to_header() that exports a cookie to a header using SimpleCookie
  • Use starlite cookie in in CSRF middleware
  • Use Cookie.to_header() in OpenAPI response

@seladb
- Add a method to parse a cookie as a header
58ddbe0 
- Use it in CSRF middleware
- Use it also in OpenAPI responses
@seladb
Merge from main
d9d34a1
@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2022

This pull request introduces 1 alert when merging d9d34a1 into b83acad - view on LGTM.com

new alerts:

  • 1 for Unused import

@seladb seladb marked this pull request as ready for review August 20, 2022 08:19
@Goldziher Goldziher merged commit 63f7061 into litestar-org:main Aug 20, 2022
@seladb seladb deleted the use-starlite-cookie-in-csrf branch September 9, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

@peterschutt peterschutt Awaiting requested review from peterschutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seladb @Goldziher