Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cognitive complexity #501

Merged
merged 6 commits into from
Sep 22, 2022

Conversation

jonadaly
Copy link
Contributor

@jonadaly jonadaly commented Sep 21, 2022

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

This PR reduces the cognitive complexity as flagged by SonarCloud (see #203) in the following modules:

  • typing.py
  • router.py
  • parsers.py
  • kwargs.py

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2022

This pull request introduces 1 alert when merging 3833d64 into c9387f8 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2022

This pull request introduces 1 alert when merging f43e972 into c9387f8 - view on LGTM.com

new alerts:

  • 1 for Unused import

@jonadaly jonadaly marked this pull request as ready for review September 21, 2022 16:53
starlite/router.py Outdated Show resolved Hide resolved
starlite/router.py Outdated Show resolved Hide resolved
starlite/router.py Outdated Show resolved Hide resolved
tests/test_parsers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@Goldziher
Copy link
Contributor

Are you on our discord? If so - shoot me a line and let's have a chat.

@Goldziher
Copy link
Contributor

invite to the org was sent to you. you can merge once youre done.

@jonadaly jonadaly merged commit 5991def into litestar-org:main Sep 22, 2022
Alex-CodeLab pushed a commit to Alex-CodeLab/starlite that referenced this pull request Sep 30, 2022
Reduce cognitive complexity of typing, router, parsers and kwards modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants