Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: migrate to pdm and full ruff #384

Merged
merged 15 commits into from
Sep 24, 2023
Merged

infra: migrate to pdm and full ruff #384

merged 15 commits into from
Sep 24, 2023

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Sep 20, 2023 •
edited
Loading

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • Move to PDM
  • Remove specific Ruff rules, use all rules as we will miss new ones by selecting specific rules.
  • Moves mypy.ini into pyproject.toml

Close Issue(s)

JacobCoffee
JacobCoffee commented Sep 20, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
polyfactory/value_generators/constrained_uuid.py Outdated Show resolved Hide resolved
guacs
guacs reviewed Sep 21, 2023
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
polyfactory/value_generators/constrained_uuid.py Outdated Show resolved Hide resolved
polyfactory/value_generators/constrained_uuid.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@guacs
Copy link
Member

guacs commented Sep 21, 2023

I think it looks good, except for a few comments. Also, I haven't taken a look at the ones that you've marked for me to investigate yet.

@adhtruong adhtruong mentioned this pull request Sep 23, 2023
Merged
5 tasks
@JacobCoffee
Copy link
Member Author

Extra CI that is expected is due to the renaming, it can be ignroed but automerge will not work here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

76.3% 76.3% Coverage
0.0% 0.0% Duplication

@JacobCoffee JacobCoffee merged commit eddb978 into main Sep 24, 2023
16 of 19 checks passed
@JacobCoffee JacobCoffee deleted the pdm_and_full_ruff branch September 24, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacs guacs guacs approved these changes

@provinzkraut provinzkraut Awaiting requested review from provinzkraut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement(Infra): Move mypy.ini into pyproject.toml
2 participants
@JacobCoffee @guacs