feat: Support SQLA14

[adhtruong]

Pull Request Checklist

• New code has 100% test coverage
• (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
• (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
• Pre-Commit Checks were ran and passed
• Tests were ran and passed

Description

• Support SQLA1.4

Close Issue(s)

• Closes Enhancement: Support SQLA v1 #376

[adhtruong]

@JacobCoffee this will most likely have conflicts with #384. Happy to help resolve conflicts depending which gets merged first.

[JacobCoffee]

@JacobCoffee this will most likely have conflicts with #384. Happy to help resolve conflicts depending which gets merged first.

It is a race, then 😝

[adhtruong]

Updated to

• Loosen the bound from 1.4.49 to 1.4. I tested locally on https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-1.4.29
• Separate out common tests to run on both and 2 specific tests.
• Add contest to examples to be skipped if 2 is not installed. This is required as they seem to run in some scenarios.

Edit: last point did not work as things are still collected so changed to omitting examples for non-latest

[guacs]

@adhtruong it seems you lost the race :P Could you resolve the conflicts?

[github-actions]

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/385

[guacs]

@adhtruong, I tried to run the tests locally with v1 on this branch but I'm getting the following error.

.venv/lib/python3.11/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
tests/sqlalchemy_factory/test_sqlalchemy_factory_common.py:123: in <module>
    tuple(SQLAlchemyFactory.get_sqlalchemy_types().keys()),
polyfactory/factories/sqlalchemy_factory.py:80: in get_sqlalchemy_types
    types.TupleType: cls.__faker__.pytuple,
E   AttributeError: module 'sqlalchemy.types' has no attribute 'TupleType'

Are you getting this locally? Or is it some issue with they way I've set it up? The commands I ran were:

source .venv/bin/activate
pdm add sqlalchemy==1.4
pytest tests

[adhtruong]

@guacs running that looks like there's two issues here:

1. pdm add sqlalchemy adds 1.4.0 by default. This is too low a version to support as that hasn't got types.TupleType. Should the patch version be added back to avoid this?
2. Separate thing noticed from this is that not sure the pipeline installation of pydantic 2 or SQLA1.4 is working. Take this run for example. I'd expect v2 only tests to have been skipped. Happy to fix up the pydantic issue as a separate PR as affecting main right now.

[guacs]

@guacs running that looks like there's two issues here:

1. pdm add sqlalchemy adds 1.4.0 by default. This is too low a version to support as that hasn't got types.TupleType. Should the patch version be added back to avoid this?
2. Separate thing noticed from this is that not sure the pipeline installation of pydantic 2 or SQLA1.4 is working. Take this run for example. I'd expect v2 only tests to have been skipped. Happy to fix up the pydantic issue as a separate PR as affecting main right now.

Okay cool. I'm going to merge this for now, but ideally, I'd like it we could support a less restrictive sqlalchemy version. It'd be great if we could support any version of sqlalchemy, but at the very least from v1.4.0 onwards. So I think we should try to see what changes we'd need to make to get it to work on the earlier versions of sqlalchemy.

Also, you're right that there seems to be something wrong with the pipelines, and it'd be a great help if you could look into that :)