Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(infra): update makefile #399

Merged
merged 2 commits into from
Oct 7, 2023
Merged

fix(infra): update makefile #399

merged 2 commits into from
Oct 7, 2023

Conversation

JacobCoffee
Copy link
Member

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • Fixes an issue with the makefile not setting the right vars

Close Issue(s)

@JacobCoffee JacobCoffee requested review from a team as code owners October 7, 2023 02:47
@JacobCoffee
chore: tabs to spaces
4b24a82 
rags to riches
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/399

@JacobCoffee JacobCoffee requested a review from guacs October 7, 2023 05:59
@JacobCoffee JacobCoffee merged commit 0064240 into main Oct 7, 2023
21 checks passed
@JacobCoffee JacobCoffee deleted the fix-makefile branch October 7, 2023 17:41
sam-or pushed a commit to sam-or/polyfactory that referenced this pull request Oct 16, 2023
@JacobCoffee @sam-or
fix(infra): update makefile (litestar-org#399)
e306abc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

@sobolevn sobolevn sobolevn approved these changes

@guacs guacs guacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobCoffee @cofin @sobolevn @guacs