Check if fields declared on the factory belong to the model (Sourcery refactored) #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
changed the title
sourcery-ai
bot
force-pushed
the
sourcery/pull-405
branch
from
7852921
to
a981be1
Compare
Comment on lines
+688
to
+695
| error_message = ( | ||
| f"{field_name} is declared on the factory {cls.__name__}" | ||
| f" but it is not part of the model {cls.__model__.__name__}" | ||
| ) | ||
| if isinstance(field_value, (Use, PostGenerated, Ignore, Require)): | ||
| raise ConfigurationException(error_message) | ||
| else: | ||
| warnings.warn(ConfigurationWarning(error_message)) |
There was a problem hiding this comment.
Function BaseFactory._check_declared_fields_exist_in_model refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #405 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!