Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decouple the handling of collection length configuration from FieldMeta #407

Merged
merged 9 commits into from
Oct 14, 2023
Merged

fix: decouple the handling of collection length configuration from FieldMeta #407

merged 9 commits into from
Oct 14, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Oct 14, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • this handles the cases where __min_collection_length__ or __max_collection_length__ are set in the get_field_value method directly instead of coupling these constraints into the created FieldMeta instances

Close Issue(s)

@sourcery-ai sourcery-ai bot mentioned this pull request Oct 14, 2023
Closed
@guacs guacs marked this pull request as ready for review October 14, 2023 17:34
@guacs guacs requested review from a team as code owners October 14, 2023 17:34
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/407

cofin
cofin approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guacs guacs merged commit 89cd351 into main Oct 14, 2023
21 checks passed
@guacs guacs deleted the decouple-collection-length branch October 14, 2023 18:36
sam-or pushed a commit to sam-or/polyfactory that referenced this pull request Oct 16, 2023
@guacs @sam-or
fix: decouple the handling of collection length configuration from `F…
f84b771 
…ieldMeta` (litestar-org#407)
@adhtruong adhtruong mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Factory does not respect randomized collection lengths for optional collection types
2 participants
@guacs @cofin