Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decouple the handling of collection length configuration from FieldMeta (Sourcery refactored) #408

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Oct 14, 2023

Pull Request #407 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the decouple-collection-length branch, then run:

git fetch origin sourcery/decouple-collection-length
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested review from a team as code owners October 14, 2023 17:31
@sourcery-ai sourcery-ai bot force-pushed the sourcery/decouple-collection-length branch 2 times, most recently from 05dd276 to a045118 Compare October 14, 2023 17:36
@sourcery-ai sourcery-ai bot force-pushed the sourcery/decouple-collection-length branch from a045118 to f0fd194 Compare October 14, 2023 17:39
try:
with suppress(ValueError):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function BaseFactory.get_constrained_field_value refactored with the following changes:

This removes the following comments ( why? ):

# implies the annotation was not a collection type

@sourcery-ai sourcery-ai bot closed this Oct 14, 2023
@sourcery-ai sourcery-ai bot deleted the sourcery/decouple-collection-length branch October 14, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants